Fix #235 #236

2018-02-16T16:14:38+01:00

Cadiducho commented

2018-02-16 16:14:38 +01:00

(Migrated from github.com)

Fixes #235

I can't really test it because I don't have access to a real Swad App Key, I only tested it changing text in radioButton in the layout, with Android Sudio

Fixes #235 I can't really test it because I don't have access to a real Swad App Key, I only tested it changing text in radioButton in the layout, with Android Sudio

Amab (Migrated from github.com) requested changes 2018-02-19 23:55:20 +01:00

Amab (Migrated from github.com) left a comment

Thank you for your contribution @Cadiducho

Your fix is ok for single choice groups (radiobutton) but removing the checkbox setText line hides the group name for multiple choice groups (checkbox).

I think the right fix is to move lines 208 and 209 into the previous else branch (multiple inscriptions) and add the radiobutton setText line to the single inscriptions branch in order to properly set the group name according to the group type (single/multiple choice).

Can you modify the fix in order to apply these changes, please?

Thank you.

Thank you for your contribution @Cadiducho Your fix is ok for single choice groups (radiobutton) but removing the checkbox setText line hides the group name for multiple choice groups (checkbox). I think the right fix is to move lines 208 and 209 into the previous else branch (multiple inscriptions) and add the radiobutton setText line to the single inscriptions branch in order to properly set the group name according to the group type (single/multiple choice). Can you modify the fix in order to apply these changes, please? Thank you.

Amab (Migrated from github.com) approved these changes 2018-02-25 13:19:20 +01:00

Sign in to join this conversation.

No reviewers

Amab