Merge 0143416856 into 0a7c196dd1

.github/pull_request_template

@@ -0,0 +1,22 @@
+<!-- Uncomment relevant sections fill relevant and delete options which are not applicable -->
+
+#### Testing the changes
+- I tested the changes in this PR: **YES**|**briefly**|**NO**
+
+<!--
+#### Change current OS
+- This PR will change current OS: **YES**|**NO**
+- Enter changed OS name: **NAME**
+-->
+
+<!--
+#### Add new OS
+- This PR will add new OS: **YES**|**NO**
+- Enter new OS name: **NAME**
+-->
+
+<!--
+#### Change something else
+- This PR will change something else: **YES**|**NO**
+- Enter short description of changes: **DESCRIPTION**
+-->

.github/workflows/lint-pr.yml

@@ -8,7 +8,7 @@ on:
       - synchronize
 
 permissions:
-  pull-requests: write
+  pull-requests: read
 
 jobs:
   main:
@@ -19,10 +19,6 @@ jobs:
         env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         with:
-          # Opt-in to using the special "[WIP]" state
-          # This will prevent the PR title from being validated, and pull
-          # request checks will remain pending.
-          wip: true
           # If the PR only contains a single commit, the action will validate that
           # it matches the configured pattern.
           validateSingleCommit: true

README.md

@@ -129,5 +129,6 @@ We welcome contributions to Quickemu.
 -   Submit [Quickemu Pull
     requests](https://github.com/quickemu-project/quickemu/pulls) to fix
     bugs 🐞 or add new features ✨
-  - Commits messages must [conform to the Conventional Commits spcification](https://www.conventionalcommits.org/).
+    -   Commit messages must [conform to the Conventional Commits
+    specification](https://www.conventionalcommits.org/).
 -   [Sponsor the project](https://github.com/sponsors/flexiondotorg) 💖

devshell.nix

@@ -6,7 +6,6 @@
   gnugrep,
   gnused,
   jq,
-  lsb-release,
   ncurses,
   nixpkgs-fmt,
   procps,
@@ -32,7 +31,6 @@ mkShell {
     gnugrep
     gnused
     jq
-    lsb-release
     ncurses
     nixpkgs-fmt
     procps

docs/quickemu.1

@@ -1,6 +1,6 @@
 .\" Automatically generated by Pandoc 3.1.13
 .\"
-.TH "QUICKEMU" "1" "May 4, 2024" "quickemu" "Quickemu User Manual"
+.TH "QUICKEMU" "1" "May 5, 2024" "quickemu" "Quickemu User Manual"
 .SH NAME
 quickemu \- A quick VM builder and manager
 .SH SYNOPSIS
@@ -264,11 +264,6 @@ jq
 .UE \c
 .IP \[bu] 2
 \c
-.UR https://wiki.linuxfoundation.org/lsb/start
-LSB
-.UE \c
-.IP \[bu] 2
-\c
 .UR https://gitlab.com/procps-ng/procps
 procps
 .UE \c
@@ -359,12 +354,12 @@ These examples may save a little typing:
 This also applies to derivatives:
 .IP
 .EX
-sudo apt install qemu bash coreutils curl ovmf grep jq lsb\-base procps python3 genisoimage usbutils util\-linux sed socat spice\-client\-gtk libtss2\-tcti\-swtpm0 xdg\-user\-dirs zsync unzip
+sudo apt install qemu bash coreutils curl ovmf grep jq procps python3 genisoimage usbutils util\-linux sed socat spice\-client\-gtk libtss2\-tcti\-swtpm0 xdg\-user\-dirs zsync unzip
 .EE
 .SS Install requirements on Fedora hosts
 .IP
 .EX
-sudo dnf install qemu bash coreutils curl edk2\-tools grep jq lsb procps python3 genisoimage usbutils util\-linux sed socat spice\-gtk\-tools swtpm xdg\-user\-dirs xrandr unzip
+sudo dnf install qemu bash coreutils curl edk2\-tools grep jq procps python3 genisoimage usbutils util\-linux sed socat spice\-gtk\-tools swtpm xdg\-user\-dirs xrandr unzip
 .EE
 .SS Install requirements on macOS hosts
 This is a \f[B]work in progress\f[R] (see \c

docs/quickemu.1.md

@@ -1,6 +1,6 @@
 ---
 author: Martin Wimpress
-date: May 4, 2024
+date: May 5, 2024
 footer: quickemu
 header: Quickemu User Manual
 section: 1
@@ -202,7 +202,6 @@ requirements manually:
 -   [EDK II](https://github.com/tianocore/edk2)
 -   [grep](https://www.gnu.org/software/grep/)
 -   [jq](https://stedolan.github.io/jq/)
--   [LSB](https://wiki.linuxfoundation.org/lsb/start)
 -   [procps](https://gitlab.com/procps-ng/procps)
 -   [python3](https://www.python.org/)
 -   [chunkcheck](https://gist.github.com/MCJack123/943eaca762730ca4b7ae460b731b68e7)
@@ -233,13 +232,13 @@ These examples may save a little typing:
 This also applies to derivatives:
 
 ``` shell
-sudo apt install qemu bash coreutils curl ovmf grep jq lsb-base procps python3 genisoimage usbutils util-linux sed socat spice-client-gtk libtss2-tcti-swtpm0 xdg-user-dirs zsync unzip
+sudo apt install qemu bash coreutils curl ovmf grep jq procps python3 genisoimage usbutils util-linux sed socat spice-client-gtk libtss2-tcti-swtpm0 xdg-user-dirs zsync unzip
 ```
 
 #### Install requirements on Fedora hosts
 
 ``` shell
-sudo dnf install qemu bash coreutils curl edk2-tools grep jq lsb procps python3 genisoimage usbutils util-linux sed socat spice-gtk-tools swtpm xdg-user-dirs xrandr unzip
+sudo dnf install qemu bash coreutils curl edk2-tools grep jq procps python3 genisoimage usbutils util-linux sed socat spice-gtk-tools swtpm xdg-user-dirs xrandr unzip
 ```
 
 #### Install requirements on macOS hosts

docs/quickemu_conf.1

@@ -1,6 +1,6 @@
 .\" Automatically generated by Pandoc 3.1.13
 .\"
-.TH "QUICKEMU_CONF" "1" "May 4, 2024" "quickemu_conf" "Quickemu Configuration Manual"
+.TH "QUICKEMU_CONF" "1" "May 5, 2024" "quickemu_conf" "Quickemu Configuration Manual"
 .SH NAME
 quickemu_conf \- Options and parameters in the quickemu <vm>.conf
 .SH DESCRIPTION

docs/quickemu_conf.1.md

@@ -1,6 +1,6 @@
 ---
 author: Martin Wimpress
-date: May 4, 2024
+date: May 5, 2024
 footer: quickemu_conf
 header: Quickemu Configuration Manual
 section: 1

docs/quickget.1

@@ -1,6 +1,6 @@
 .\" Automatically generated by Pandoc 3.1.13
 .\"
-.TH "QUICKGET" "1" "May 4, 2024" "quickget" "Quickget User Manual"
+.TH "QUICKGET" "1" "May 5, 2024" "quickget" "Quickget User Manual"
 .SH NAME
 quickget \- download and prepare materials for building a quickemu VM
 .SH SYNOPSIS

docs/quickget.1.md

@@ -1,6 +1,6 @@
 ---
 author: Martin Wimpress
-date: May 4, 2024
+date: May 5, 2024
 footer: quickget
 header: Quickget User Manual
 section: 1

package.nix

@@ -9,7 +9,6 @@
 , gnugrep
 , gnused
 , jq
-, lsb-release
 , ncurses
 , procps
 , python3
@@ -33,7 +32,6 @@ let
     gnugrep
     gnused
     jq
-    lsb-release
     ncurses
     procps
     python3

quickemu

@@ -245,9 +245,7 @@ function vm_boot() {
     KERNEL_NODE="($(uname --nodename))"
     KERNEL_VER=$(uname --kernel-release | cut -d'.' -f1-2)
 
-    if command -v lsb_release &>/dev/null; then
-        LSB_DESCRIPTION=$(lsb_release --description --short)
-    elif [ -e /etc/os-release ]; then
+    if [ -e /etc/os-release ]; then
         LSB_DESCRIPTION=$(grep PRETTY_NAME /etc/os-release | cut -d'"' -f2)
     fi
     # Strip quotes from LSB_DESCRIPTION