Indoor Location new module #287

2020-09-06T11:27:12+02:00

JaviBL8 commented

2020-09-06 11:27:12 +02:00

(Migrated from github.com)

What changes were proposed in this pull request?

Indoor Location based in WiFi signal power and mapping all physical addresses of routers in a center

How was this patch tested?

Manual testing in ETSIIT

Please review https://github.com/Amab/SWADroid/blob/develop/CONTRIBUTING.md before opening a pull request.

## What changes were proposed in this pull request? Indoor Location based in WiFi signal power and mapping all physical addresses of routers in a center ## How was this patch tested? Manual testing in ETSIIT Please review https://github.com/Amab/SWADroid/blob/develop/CONTRIBUTING.md before opening a pull request.

Amab (Migrated from github.com) requested changes 2020-09-12 16:02:31 +02:00

Amab (Migrated from github.com) left a comment

When the indoor location history is empty, the screen should be displayed with a message informing that the history is empty to prevent the user from thinking that a problem has occurred when loading the history.

Is the location history always downloaded from the server? If there is no connection to the server at the time the user checks the history, can't the history be checked?

What is the behavior of the indoor location in the following cases?

The server does not have the mapping of the wifi routers of the center where the user is located loaded
The center where the user is located does not have wifi routers. This point also includes the case that the user leaves the center and is out of reach of wifi routers

When the indoor location history is empty, the screen should be displayed with a message informing that the history is empty to prevent the user from thinking that a problem has occurred when loading the history. Is the location history always downloaded from the server? If there is no connection to the server at the time the user checks the history, can't the history be checked? What is the behavior of the indoor location in the following cases? - The server does not have the mapping of the wifi routers of the center where the user is located loaded - The center where the user is located does not have wifi routers. This point also includes the case that the user leaves the center and is out of reach of wifi routers

SWADroid/src/main/java/es/ugr/swad/swadroid/model/LocationTimeStamp.java

Amab (Migrated from github.com) commented

2020-09-12 13:21:55 +02:00

All these fields are already contained in the Location class. You can make LocationTimestamp extend from Location to inherit those fields so you don't have to duplicate them.

All these fields are already contained in the Location class. You can make `LocationTimestamp` extend from `Location` to inherit those fields so you don't have to duplicate them.

Amab (Migrated from github.com) requested changes 2020-09-22 18:07:20 +02:00

Amab (Migrated from github.com) requested changes 2020-09-29 19:43:13 +02:00

Amab (Migrated from github.com) left a comment

When you open the module, it closes immediately in some versions of Android:

Android 11 (API 30): FAIL
Android 10 (API 29): OK
Android 6 (API 24): FAIL (shows exception java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener")

When you open the module, it closes immediately in some versions of Android: - Android 11 (API 30): **FAIL** - Android 10 (API 29): OK - Android 6 (API 24): **FAIL** (shows exception `java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener"`)

Amab commented

2020-10-13 21:48:16 +02:00

(Migrated from github.com)

When you open the module, it closes immediately in some versions of Android:

* Android 11 (API 30): **FAIL**

* Android 10 (API 29): OK

* Android 6 (API 24): **FAIL** (shows exception `java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener"`)

Update:

I have investigated the errors and they seem to have to do with the use of the ACCESS_BACKGROUND_LOCATION permission, which is only available from Android 10 (API 29) and higher. If this permission is removed, the module will work correctly in the three Android versions listed above.

I think it would be necessary to remove the @RequiresApi(api = Build.VERSION_CODES.Q) annotation from the onStart method of the IndoorLocation class and manage the permissions taking into account that the application must run correctly in at least the three Android versions listed above.

> When you open the module, it closes immediately in some versions of Android: > > * Android 11 (API 30): **FAIL** > > * Android 10 (API 29): OK > > * Android 6 (API 24): **FAIL** (shows exception `java.lang.ClassNotFoundException: Didn't find class "android.view.View$OnUnhandledKeyEventListener"`) Update: I have investigated the errors and they seem to have to do with the use of the `ACCESS_BACKGROUND_LOCATION` permission, which is only available from **Android 10 (API 29) and higher**. If this permission is removed, the module will work correctly in the three Android versions listed above. I think it would be necessary to remove the `@RequiresApi(api = Build.VERSION_CODES.Q)` annotation from the `onStart` method of the `IndoorLocation` class and manage the permissions taking into account that the application must run correctly in at least the three Android versions listed above.

Amab (Migrated from github.com) reviewed 2020-10-14 18:00:13 +02:00

Amab (Migrated from github.com) approved these changes 2020-10-14 19:49:46 +02:00

Amab (Migrated from github.com) left a comment

LGTM

Sign in to join this conversation.

No reviewers

Amab