diff --git a/source/de/anomic/crawler/CrawlQueues.java b/source/de/anomic/crawler/CrawlQueues.java index 032ef3239..d4695f96a 100644 --- a/source/de/anomic/crawler/CrawlQueues.java +++ b/source/de/anomic/crawler/CrawlQueues.java @@ -522,7 +522,7 @@ public class CrawlQueues { protected Request request; private final Integer code; - private long start; + private final long start; public crawlWorker(final Request entry) { this.start = System.currentTimeMillis(); diff --git a/source/de/anomic/data/bookmarksDB.java b/source/de/anomic/data/bookmarksDB.java index d9ab13452..426a623a8 100644 --- a/source/de/anomic/data/bookmarksDB.java +++ b/source/de/anomic/data/bookmarksDB.java @@ -104,7 +104,7 @@ public class bookmarksDB { MapView datesTable; // autoReCrawl - private BusyThread autoReCrawl; + private final BusyThread autoReCrawl; // ------------------------------------ // bookmarksDB's class constructor diff --git a/source/de/anomic/search/ReferenceOrder.java b/source/de/anomic/search/ReferenceOrder.java index f8294fce6..6f4646730 100644 --- a/source/de/anomic/search/ReferenceOrder.java +++ b/source/de/anomic/search/ReferenceOrder.java @@ -49,7 +49,7 @@ public class ReferenceOrder { protected WordReferenceVars min, max; protected final ScoreCluster doms; // collected for "authority" heuristic private final RankingProfile ranking; - private String language; + private final String language; public ReferenceOrder(final RankingProfile profile, String language) { this.min = null; diff --git a/source/de/anomic/server/serverObjects.java b/source/de/anomic/server/serverObjects.java index d1012a68e..b0916c7d8 100644 --- a/source/de/anomic/server/serverObjects.java +++ b/source/de/anomic/server/serverObjects.java @@ -53,6 +53,7 @@ import java.util.HashMap; import java.util.Map; import net.yacy.document.parser.html.CharacterCoding; +import net.yacy.kelondro.data.meta.DigestURI; import net.yacy.kelondro.logging.Log; import net.yacy.kelondro.util.DateFormatter; import net.yacy.kelondro.util.Formatter; @@ -360,9 +361,9 @@ public class serverObjects extends HashMap implements Cloneable if (this.size() == 0) return ""; StringBuilder param = new StringBuilder(); for (Map.Entry entry: this.entrySet()) { - param.append(entry.getKey()); + param.append(DigestURI.escape(entry.getKey())); param.append('='); - param.append(entry.getValue()); + param.append(DigestURI.escape(entry.getValue())); param.append('&'); } param.setLength(param.length() - 1); diff --git a/source/de/anomic/yacy/Tray.java b/source/de/anomic/yacy/Tray.java index adc75f50b..f34c058f4 100644 --- a/source/de/anomic/yacy/Tray.java +++ b/source/de/anomic/yacy/Tray.java @@ -218,7 +218,7 @@ class nativeTrayIcon { Method setImageAutoSizeMethod = TrayIconClass.getMethod("setImageAutoSize", partypes2); Object arglist2[] = new Object[1]; - arglist2[0] = Boolean.valueOf(true); + arglist2[0] = Boolean.TRUE; setImageAutoSizeMethod.invoke(this.TrayIcon, arglist2); // with reflections: this.TrayIcon.addActionListener(al) diff --git a/source/de/anomic/yacy/yacySeedDB.java b/source/de/anomic/yacy/yacySeedDB.java index db3e2bf0a..47dc2d82d 100644 --- a/source/de/anomic/yacy/yacySeedDB.java +++ b/source/de/anomic/yacy/yacySeedDB.java @@ -89,7 +89,7 @@ public final class yacySeedDB implements AlternativeDomainNames { public yacyPeerActions peerActions; public yacyNewsPool newsPool; - private int netRedundancy; + private final int netRedundancy; public PartitionScheme scheme; private yacySeed mySeed; // my own seed diff --git a/source/de/anomic/yacy/yacyUpdateLocation.java b/source/de/anomic/yacy/yacyUpdateLocation.java index de984d273..8f38adc66 100644 --- a/source/de/anomic/yacy/yacyUpdateLocation.java +++ b/source/de/anomic/yacy/yacyUpdateLocation.java @@ -37,8 +37,8 @@ import net.yacy.kelondro.data.meta.DigestURI; * */ public class yacyUpdateLocation { - private DigestURI locationURL; - private PublicKey publicKey; + private final DigestURI locationURL; + private final PublicKey publicKey; public yacyUpdateLocation(DigestURI locationURL, PublicKey publicKey) { this.locationURL = locationURL; diff --git a/source/net/sbbi/upnp/ServicesEventing.java b/source/net/sbbi/upnp/ServicesEventing.java index ee8eb9b48..c06d5ae04 100644 --- a/source/net/sbbi/upnp/ServicesEventing.java +++ b/source/net/sbbi/upnp/ServicesEventing.java @@ -89,7 +89,7 @@ public class ServicesEventing implements Runnable { private ServerSocket server = null; - private List registered = new ArrayList(); + private final List registered = new ArrayList(); private ServicesEventing() { } @@ -359,9 +359,9 @@ public class ServicesEventing implements Runnable { class RequestProcessor implements Runnable { - private Socket client; + private final Socket client; - RequestProcessor( Socket client ) { + RequestProcessor(final Socket client) { this.client = client; } diff --git a/source/net/sbbi/upnp/services/UPNPService.java b/source/net/sbbi/upnp/services/UPNPService.java index 543a9b6a6..a762f107b 100644 --- a/source/net/sbbi/upnp/services/UPNPService.java +++ b/source/net/sbbi/upnp/services/UPNPService.java @@ -77,7 +77,7 @@ public class UPNPService { protected Map UPNPServiceActions; protected Map UPNPServiceStateVariables; - private String USN; + private final String USN; private boolean parsedSCPD = false; private DocumentContainer UPNPService; diff --git a/source/net/yacy/document/content/dao/ImportDump.java b/source/net/yacy/document/content/dao/ImportDump.java index c78a5701a..59dc8c5e3 100644 --- a/source/net/yacy/document/content/dao/ImportDump.java +++ b/source/net/yacy/document/content/dao/ImportDump.java @@ -36,7 +36,7 @@ import net.yacy.kelondro.util.FileUtils; public class ImportDump { - private DatabaseConnection conn = null; + private final DatabaseConnection conn; public ImportDump( String dbType, diff --git a/source/net/yacy/yacy.java b/source/net/yacy/yacy.java index 9d8096bf7..aa0aec1e6 100644 --- a/source/net/yacy/yacy.java +++ b/source/net/yacy/yacy.java @@ -1039,8 +1039,8 @@ public final class yacy { * machine shuts down. Signals the plasmaSwitchboard to shut down. */ class shutdownHookThread extends Thread { - private Switchboard sb = null; - private Thread mainThread = null; + private final Switchboard sb; + private final Thread mainThread; public shutdownHookThread(final Thread mainThread, final Switchboard sb) { super();