diff --git a/swad_changelog.h b/swad_changelog.h index c161dbae7..4bc6b29fc 100644 --- a/swad_changelog.h +++ b/swad_changelog.h @@ -598,10 +598,11 @@ TODO: DNI de un estudiante sale err TODO: BUG: Cuando un tipo de grupo sólo tiene un grupo, inscribirse es voluntario, el estudiante sólo puede pertenecer a un grupo, y se inscribe en él, debería poder desapuntarse. Ahora no puede. TODO: Salvador Romero Cortés: @acanas opción para editar posts */ -#define Log_PLATFORM_VERSION "SWAD 20.39.8 (2021-03-02)" +#define Log_PLATFORM_VERSION "SWAD 20.39.9 (2021-03-02)" #define CSS_FILE "swad20.33.9.css" #define JS_FILE "swad20.6.2.js" /* + Version 20.39.9: Mar 02, 2021 Code refactoring in timeline. (305580 lines) Version 20.39.8: Mar 02, 2021 Code refactoring in timeline. (305573 lines) Version 20.39.7: Mar 02, 2021 Code refactoring in fav/share timeline comments. (305566 lines) Version 20.39.6: Mar 02, 2021 Code refactoring in fav/share timeline notes. (305570 lines) diff --git a/swad_timeline.c b/swad_timeline.c index 5be48109c..f50766816 100644 --- a/swad_timeline.c +++ b/swad_timeline.c @@ -170,6 +170,8 @@ static void TL_PutIconsTimeline (__attribute__((unused)) void *Args); static unsigned TL_ListRecentPubs (struct TL_Timeline *Timeline, long NotCodToHighlight); +static void TL_PutHiddenList (const char *Id); + /*****************************************************************************/ /************************ Initialize global timeline *************************/ /*****************************************************************************/ @@ -443,15 +445,11 @@ static void TL_ShowTimeline (struct TL_Timeline *Timeline, /* Link to view new publications via AJAX */ TL_Pub_PutLinkToViewNewPubs (); - /* Hidden list where insert - just received (not visible) publications via AJAX */ - HTM_UL_Begin ("id=\"just_now_timeline_list\" class=\"TL_LIST\""); - HTM_UL_End (); - - /* Hidden list where insert - new (not visible) publications via AJAX */ - HTM_UL_Begin ("id=\"new_timeline_list\" class=\"TL_LIST\""); - HTM_UL_End (); + /* Hidden lists to insert publications received via AJAX: + 1. just received (not visible) publications + 2. new (not visible) publications */ + TL_PutHiddenList ("just_now_timeline_list"); + TL_PutHiddenList ("new_timeline_list"); } /***** List recent publications in timeline *****/ @@ -464,9 +462,8 @@ static void TL_ShowTimeline (struct TL_Timeline *Timeline, /* Link to view old publications via AJAX */ TL_Pub_PutLinkToViewOldPubs (); - /* Hidden list where insert old publications via AJAX */ - HTM_UL_Begin ("id=\"old_timeline_list\" class=\"TL_LIST\""); - HTM_UL_End (); + /* Hidden list to insert old publications via AJAX */ + TL_PutHiddenList ("old_timeline_list"); } /***** End box *****/ @@ -508,8 +505,9 @@ static unsigned TL_ListRecentPubs (struct TL_Timeline *Timeline, TL_Not_GetDataOfNoteByCod (&Not); /* Write list item (note) */ - HTM_LI_Begin ("class=\"%s\"",Not.NotCod == NotCodToHighlight ? "TL_WIDTH TL_SEP TL_NEW_PUB" : - "TL_WIDTH TL_SEP"); + HTM_LI_Begin ("class=\"%s\"", + Not.NotCod == NotCodToHighlight ? "TL_WIDTH TL_SEP TL_NEW_PUB" : + "TL_WIDTH TL_SEP"); TL_Not_CheckAndWriteNoteWithTopMsg (Timeline,&Not, TL_Pub_GetTopMessage (Pub->PubType), Pub->PublisherCod); @@ -522,6 +520,16 @@ static unsigned TL_ListRecentPubs (struct TL_Timeline *Timeline, return NumNotesShown; } +/*****************************************************************************/ +/*********** Put a hidden list where publications will be inserted ***********/ +/*****************************************************************************/ + +static void TL_PutHiddenList (const char *Id) + { + HTM_UL_Begin ("id=\"%s\" class=\"TL_LIST\"",Id); + HTM_UL_End (); + } + /*****************************************************************************/ /******************* Write the date of creation of a note ********************/ /*****************************************************************************/