diff --git a/swad_changelog.h b/swad_changelog.h index 011a4640c..90681624a 100644 --- a/swad_changelog.h +++ b/swad_changelog.h @@ -355,10 +355,11 @@ En OpenSWAD: ps2pdf source.ps destination.pdf */ -#define Log_PLATFORM_VERSION "SWAD 18.8.18 (2018-10-28)" +#define Log_PLATFORM_VERSION "SWAD 18.9 (2018-10-28)" #define CSS_FILE "swad18.4.css" #define JS_FILE "swad17.17.1.js" /* + Version 18.9: Oct 28, 2018 Some sprintf for database queries changed by internal function. (236082 lines) Version 18.8.18: Oct 28, 2018 Some asprintf for database queries changed by internal function. (236105 lines) Version 18.8.17: Oct 28, 2018 Some asprintf for database queries changed by internal function. (236116 lines) Version 18.8.16: Oct 28, 2018 Some asprintf for database queries changed by internal function. (236263 lines) diff --git a/swad_database.c b/swad_database.c index 0f0ea0236..e265debaf 100644 --- a/swad_database.c +++ b/swad_database.c @@ -3359,13 +3359,6 @@ void DB_Query_new (const char *MsgError) DB_ExitOnMySQLError (MsgError); } -void DB_Query (const char *Query,const char *MsgError) - { - /***** Query database *****/ - if (mysql_query (&Gbl.mysql,Query)) - DB_ExitOnMySQLError (MsgError); - } - /*****************************************************************************/ /********** Free structure that stores the result of a SELECT query **********/ /*****************************************************************************/ diff --git a/swad_database.h b/swad_database.h index 8d2956477..601e29a18 100644 --- a/swad_database.h +++ b/swad_database.h @@ -61,7 +61,6 @@ void DB_QueryDELETE_new (const char *MsgError); void DB_QueryDELETE (const char *Query,const char *MsgError); void DB_Query_new (const char *MsgError); -void DB_Query (const char *Query,const char *MsgError); void DB_FreeMySQLResult (MYSQL_RES **mysql_res); void DB_ExitOnMySQLError (const char *Message); diff --git a/swad_report.c b/swad_report.c index 108bbae1e..45d925f72 100644 --- a/swad_report.c +++ b/swad_report.c @@ -1437,9 +1437,7 @@ static void Rep_RemoveUsrReportsFiles (long UsrCod) static void Rep_RemoveUsrReportsFromDB (long UsrCod) { - char Query[128]; - /***** Insert a new user's usage report into database *****/ - sprintf (Query,"DELETE FROM usr_report WHERE UsrCod=%ld",UsrCod); - DB_QueryDELETE (Query,"can not remove user's usage reports"); + DB_BuildQuery ("DELETE FROM usr_report WHERE UsrCod=%ld",UsrCod); + DB_QueryDELETE_new ("can not remove user's usage reports"); } diff --git a/swad_session.c b/swad_session.c index 99f5c4a54..06c667d0f 100644 --- a/swad_session.c +++ b/swad_session.c @@ -230,12 +230,9 @@ void Ses_UpdateSessionLastRefreshInDB (void) static void Ses_RemoveSessionFromDB (void) { - char Query[128 + Cns_BYTES_SESSION_ID]; - /***** Remove current session *****/ - sprintf (Query,"DELETE FROM sessions WHERE SessionId='%s'", - Gbl.Session.Id); - DB_QueryDELETE (Query,"can not remove a session"); + DB_BuildQuery ("DELETE FROM sessions WHERE SessionId='%s'",Gbl.Session.Id); + DB_QueryDELETE_new ("can not remove a session"); /***** Clear old unused social timelines in database *****/ // This is necessary to prevent the table growing and growing @@ -248,22 +245,20 @@ static void Ses_RemoveSessionFromDB (void) void Ses_RemoveExpiredSessions (void) { - char Query[1024]; - /***** Remove expired sessions *****/ /* A session expire when last click (LastTime) is too old, or (when there was at least one refresh (navigator supports AJAX) and last refresh is too old (browser probably was closed)) */ - sprintf (Query,"DELETE LOW_PRIORITY FROM sessions WHERE" + DB_BuildQuery ("DELETE LOW_PRIORITY FROM sessions WHERE" " LastTimeLastTime+INTERVAL 1 SECOND" " AND" " LastRefresh