diff --git a/swad_agenda.c b/swad_agenda.c index 305f93fd..f5e9713b 100644 --- a/swad_agenda.c +++ b/swad_agenda.c @@ -676,7 +676,6 @@ static void Agd_PutIconToShowQR (void) Cfg_URL_SWAD_CGI, Lan_STR_LANG_ID[Gbl.Prefs.Language], Gbl.Usrs.Me.UsrDat.Nickname); - Gbl.QR.Str = URL; QR_PutLinkToPrintQRCode (ActPrnAgdQR, QR_PutParamQRString,URL); } diff --git a/swad_attendance.c b/swad_attendance.c index 8c68ce8e..49599684 100644 --- a/swad_attendance.c +++ b/swad_attendance.c @@ -171,8 +171,8 @@ static void Att_PutParamsToPrintStdsList (void *Events); static void Att_PutButtonToShowDetails (const struct Att_Events *Events); static void Att_ListEventsToSelect (const struct Att_Events *Events, Att_TypeOfView_t TypeOfView); -static void Att_PutIconToViewAttEvents (void *Events); -static void Att_PutIconToEditAttEvents (void *Events); +static void Att_PutIconToViewAttEvents (__attribute__((unused)) void *Args); +static void Att_PutIconToEditAttEvents (__attribute__((unused)) void *Args); static void Att_ListUsrsAttendanceTable (const struct Att_Events *Events, Att_TypeOfView_t TypeOfView, unsigned NumUsrsInList, @@ -3202,12 +3202,12 @@ static void Att_ListEventsToSelect (const struct Att_Events *Events, { case Att_VIEW_ONLY_ME: Box_BoxBegin (NULL,Txt_Events, - Att_PutIconToViewAttEvents,&Events, + Att_PutIconToViewAttEvents,NULL, NULL,Box_NOT_CLOSABLE); break; case Att_VIEW_SEL_USR: Box_BoxBegin (NULL,Txt_Events, - Att_PutIconToEditAttEvents,&Events, + Att_PutIconToEditAttEvents,NULL, NULL,Box_NOT_CLOSABLE); break; case Att_PRNT_ONLY_ME: @@ -3319,22 +3319,20 @@ static void Att_ListEventsToSelect (const struct Att_Events *Events, /*********** Put icon to list (without edition) attendance events ************/ /*****************************************************************************/ -static void Att_PutIconToViewAttEvents (void *Events) +static void Att_PutIconToViewAttEvents (__attribute__((unused)) void *Args) { - if (Events) // Not used - Ico_PutContextualIconToView (ActSeeAtt, - NULL,NULL); + Ico_PutContextualIconToView (ActSeeAtt, + NULL,NULL); } /*****************************************************************************/ /************ Put icon to list (with edition) attendance events **************/ /*****************************************************************************/ -static void Att_PutIconToEditAttEvents (void *Events) +static void Att_PutIconToEditAttEvents (__attribute__((unused)) void *Args) { - if (Events) // Not used - Ico_PutContextualIconToEdit (ActSeeAtt,NULL, - NULL,NULL); + Ico_PutContextualIconToEdit (ActSeeAtt,NULL, + NULL,NULL); } /*****************************************************************************/ diff --git a/swad_banner.c b/swad_banner.c index 796123db..079cba81 100644 --- a/swad_banner.c +++ b/swad_banner.c @@ -78,7 +78,7 @@ static void Ban_SetEditingBanner (struct Ban_Banner *Ban); static struct Ban_Banner *Ban_GetEditingBanner (void); static void Ban_WriteListOfBanners (const struct Ban_Banners *Banners); -static void Ban_PutIconsListingBanners (void *Banners); +static void Ban_PutIconsListingBanners (__attribute__((unused)) void *Args); static void Ban_PutIconToEditBanners (void); static void Ban_EditBannersInternal (struct Ban_Banners *Banners, const struct Ban_Banner *Ban); @@ -86,7 +86,7 @@ static void Ban_GetListBanners (struct Ban_Banners *Banners, MYSQL_RES **mysql_res,unsigned long NumRows); static void Ban_FreeListBanners (struct Ban_Banners *Banners); -static void Ban_PutIconsEditingBanners (void *Banners); +static void Ban_PutIconsEditingBanners (__attribute__((unused)) void *Args); static void Ban_ListBannersForEdition (struct Ban_Banners *Banners); static void Ban_PutParamBanCodToEdit (void *BanCod); @@ -149,7 +149,7 @@ void Ban_SeeBanners (void) /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Banners, - Ban_PutIconsListingBanners,&Banners, + Ban_PutIconsListingBanners,NULL, Hlp_SYSTEM_Banners,Box_NOT_CLOSABLE); /***** Write all banners *****/ @@ -208,17 +208,14 @@ static void Ban_WriteListOfBanners (const struct Ban_Banners *Banners) /***************** Put contextual icons in list of banners *******************/ /*****************************************************************************/ -static void Ban_PutIconsListingBanners (void *Banners) +static void Ban_PutIconsListingBanners (__attribute__((unused)) void *Args) { - if (Banners) // Not used - { - /***** Put icon to view banners *****/ - if (Gbl.Usrs.Me.Role.Logged == Rol_SYS_ADM) - Ban_PutIconToEditBanners (); + /***** Put icon to view banners *****/ + if (Gbl.Usrs.Me.Role.Logged == Rol_SYS_ADM) + Ban_PutIconToEditBanners (); - /***** Put icon to view links *****/ - Lnk_PutIconToViewLinks (); - } + /***** Put icon to view links *****/ + Lnk_PutIconToViewLinks (); } /*****************************************************************************/ @@ -266,7 +263,7 @@ static void Ban_EditBannersInternal (struct Ban_Banners *Banners, /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Banners, - Ban_PutIconsEditingBanners,Banners, + Ban_PutIconsEditingBanners,NULL, Hlp_SYSTEM_Banners_edit,Box_NOT_CLOSABLE); /***** Put a form to create a new banner *****/ @@ -416,16 +413,13 @@ static void Ban_FreeListBanners (struct Ban_Banners *Banners) /**************** Put contextual icons in edition of banners *****************/ /*****************************************************************************/ -static void Ban_PutIconsEditingBanners (void *Banners) +static void Ban_PutIconsEditingBanners (__attribute__((unused)) void *Args) { - if (Banners) // Not used - { - /***** Put icon to view banners *****/ - Ban_PutIconToViewBanners (); + /***** Put icon to view banners *****/ + Ban_PutIconToViewBanners (); - /***** Put icon to view links *****/ - Lnk_PutIconToViewLinks (); - } + /***** Put icon to view links *****/ + Lnk_PutIconToViewLinks (); } /*****************************************************************************/ diff --git a/swad_calendar.c b/swad_calendar.c index 96d23060..236085a6 100644 --- a/swad_calendar.c +++ b/swad_calendar.c @@ -62,7 +62,7 @@ const bool Cal_DayIsValidAsFirstDayOfWeek[7] = /***************************** Private prototypes ****************************/ /*****************************************************************************/ -static void Cal_PutIconsFirstDayOfWeek (void *Args); +static void Cal_PutIconsFirstDayOfWeek (__attribute__((unused)) void *Args); static unsigned Cal_GetParamFirstDayOfWeek (void); @@ -82,7 +82,7 @@ void Cal_PutIconsToSelectFirstDayOfWeek (void) extern const char *Txt_Calendar; Box_BoxBegin (NULL,Txt_Calendar, - Cal_PutIconsFirstDayOfWeek,&Gbl, + Cal_PutIconsFirstDayOfWeek,NULL, Hlp_PROFILE_Settings_calendar,Box_NOT_CLOSABLE); Set_StartSettingsHead (); Cal_ShowFormToSelFirstDayOfWeek (ActChg1stDay, @@ -95,11 +95,10 @@ void Cal_PutIconsToSelectFirstDayOfWeek (void) /************ Put contextual icons in first-day-of-week setting **************/ /*****************************************************************************/ -static void Cal_PutIconsFirstDayOfWeek (void *Args) +static void Cal_PutIconsFirstDayOfWeek (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_FIRST_DAY_OF_WEEK); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_FIRST_DAY_OF_WEEK); } /*****************************************************************************/ diff --git a/swad_changelog.h b/swad_changelog.h index 9be0ccba..a9af645e 100644 --- a/swad_changelog.h +++ b/swad_changelog.h @@ -497,7 +497,7 @@ enscript -2 --landscape --color --file-align=2 --highlight --line-numbers -o - * En OpenSWAD: ps2pdf source.ps destination.pdf */ -#define Log_PLATFORM_VERSION "SWAD 19.169 (2020-04-08)" +#define Log_PLATFORM_VERSION "SWAD 19.169.1 (2020-04-08)" #define CSS_FILE "swad19.146.css" #define JS_FILE "swad19.153.js" /* @@ -548,6 +548,7 @@ Funci // TODO: Oresti Baños: cambiar ojos por candados en descriptores para prohibir/permitir y dejar los ojos para poder elegir descriptores // TODO: Integrar pull requests con traducciones del alemán del usuario eruedin en GitHub + Version 19.169.1: Apr 08, 2020 Mark some parameters as unused. (284999 lines) Version 19.169: Apr 08, 2020 Code refactoring in games and matches. (285024 lines) Version 19.168: Apr 07, 2020 Code refactoring in forums. (284866 lines) Version 19.167: Apr 06, 2020 Code refactoring in figures. (284772 lines) diff --git a/swad_cookie.c b/swad_cookie.c index 1832375c..baff62d0 100644 --- a/swad_cookie.c +++ b/swad_cookie.c @@ -52,7 +52,7 @@ extern struct Globals Gbl; /***************************** Private prototypes ****************************/ /*****************************************************************************/ -static void Coo_PutIconsCookies (void *Args); +static void Coo_PutIconsCookies (__attribute__((unused)) void *Args); /*****************************************************************************/ /********************* Edit my preferences on cookies ************************/ @@ -69,7 +69,7 @@ void Coo_EditMyPrefsOnCookies (void) /***** Begin box and table *****/ Box_BoxTableBegin (NULL,Txt_Cookies, - Coo_PutIconsCookies,&Gbl, + Coo_PutIconsCookies,NULL, Hlp_PROFILE_Settings_cookies,Box_NOT_CLOSABLE,2); /***** Edit my preference about cookies *****/ @@ -102,11 +102,10 @@ void Coo_EditMyPrefsOnCookies (void) /***************** Put contextual icons in cookies preference ****************/ /*****************************************************************************/ -static void Coo_PutIconsCookies (void *Args) +static void Coo_PutIconsCookies (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_COOKIES); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_COOKIES); } /*****************************************************************************/ diff --git a/swad_date.c b/swad_date.c index a73770b9..45ed0582 100644 --- a/swad_date.c +++ b/swad_date.c @@ -94,7 +94,7 @@ static const unsigned Dat_NumDaysMonth[1 + 12] = /**************************** Private prototypes *****************************/ /*****************************************************************************/ -static void Dat_PutIconsDateFormat (void *Args); +static void Dat_PutIconsDateFormat (__attribute__((unused)) void *Args); static unsigned Dat_GetParamDateFormat (void); /*****************************************************************************/ @@ -109,7 +109,7 @@ void Dat_PutBoxToSelectDateFormat (void) /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Dates, - Dat_PutIconsDateFormat,&Gbl, + Dat_PutIconsDateFormat,NULL, Hlp_PROFILE_Settings_dates,Box_NOT_CLOSABLE); /***** Form with list of options *****/ @@ -147,11 +147,10 @@ void Dat_PutBoxToSelectDateFormat (void) /*************** Put contextual icons in date-format setting *****************/ /*****************************************************************************/ -static void Dat_PutIconsDateFormat (void *Args) +static void Dat_PutIconsDateFormat (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_DATE_FORMAT); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_DATE_FORMAT); } /*****************************************************************************/ diff --git a/swad_file_browser.c b/swad_file_browser.c index 714f7fb7..30b3ff3e 100644 --- a/swad_file_browser.c +++ b/swad_file_browser.c @@ -1284,7 +1284,7 @@ static void Brw_GetSelectedGroupData (struct GroupData *GrpDat,bool AbortOnError static void Brw_ShowDataOwnerAsgWrk (struct UsrData *UsrDat); static void Brw_ShowFileBrowser (void); static void Brw_PutIconsFileBrowser (void *Args); -static void Brw_PutIconShowFigure (void *Args); +static void Brw_PutIconShowFigure (__attribute__((unused)) void *Args); static void Brw_PutButtonToShowEdit (void); static void Brw_WriteTopBeforeShowingFileBrowser (void); static void Brw_UpdateLastAccess (void); @@ -2341,7 +2341,7 @@ static void Brw_PutParamsFileBrowser (const char *PathInTree,const char *FilFolL } /***** If full tree selected? *****/ - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); /***** Path and file *****/ if (PathInTree) @@ -3206,7 +3206,7 @@ static void Brw_ShowFileBrowsersAsgWrkCrs (void) /***** Begin box and table *****/ Box_BoxTableBegin ("100%",Txt_Assignments_and_other_works, - Brw_PutIconShowFigure,&Gbl, + Brw_PutIconShowFigure,NULL, Hlp_FILES_Homework_for_teachers,Box_NOT_CLOSABLE,0); /***** List the assignments and works of the selected users *****/ @@ -3296,7 +3296,7 @@ static void Brw_FormToChangeCrsGrpZone (void) /***** Begin form *****/ Frm_StartForm (Brw_ActChgZone[Gbl.FileBrowser.Type]); - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); /***** List start *****/ HTM_UL_Begin ("class=\"LIST_LEFT\""); @@ -3736,11 +3736,11 @@ static void Brw_PutIconsFileBrowser (void *Args) break; case Brw_ICON_VIEW: Ico_PutContextualIconToView (Brw_ActFromAdmToSee[Gbl.FileBrowser.Type], - Brw_PutHiddenParamFullTreeIfSelected,&Gbl); + Brw_PutHiddenParamFullTreeIfSelected,&Gbl.FileBrowser.FullTree); break; case Brw_ICON_EDIT: Ico_PutContextualIconToEdit (Brw_ActFromSeeToAdm[Gbl.FileBrowser.Type],NULL, - Brw_PutHiddenParamFullTreeIfSelected,&Gbl); + Brw_PutHiddenParamFullTreeIfSelected,&Gbl.FileBrowser.FullTree); break; } @@ -3753,16 +3753,16 @@ static void Brw_PutIconsFileBrowser (void *Args) case Brw_ADMI_ASS_PRJ: break; default: - Brw_PutIconShowFigure (&Gbl); + Brw_PutIconShowFigure (NULL); break; } } } -static void Brw_PutIconShowFigure (void *Args) +static void Brw_PutIconShowFigure (__attribute__((unused)) void *Args) { - if (Args) - Fig_PutIconToShowFigure (Fig_FOLDERS_AND_FILES); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_FOLDERS_AND_FILES); } /*****************************************************************************/ @@ -3782,7 +3782,7 @@ static void Brw_PutButtonToShowEdit (void) if (Brw_ActFromAdmToSee[Gbl.FileBrowser.Type] != ActUnk) { Frm_StartForm (Brw_ActFromAdmToSee[Gbl.FileBrowser.Type]); - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); Btn_PutConfirmButton (Txt_View); Frm_EndForm (); } @@ -3791,7 +3791,7 @@ static void Brw_PutButtonToShowEdit (void) if (Brw_ActFromSeeToAdm[Gbl.FileBrowser.Type] != ActUnk) { Frm_StartForm (Brw_ActFromSeeToAdm[Gbl.FileBrowser.Type]); - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); Btn_PutConfirmButton (Txt_Edit); Frm_EndForm (); } @@ -4986,10 +4986,10 @@ static void Brw_PutParamsFullTree (void) /********* Put hidden parameter "full tree" if full tree is selected *********/ /*****************************************************************************/ -void Brw_PutHiddenParamFullTreeIfSelected (void *Args) +void Brw_PutHiddenParamFullTreeIfSelected (void *FullTree) { - if (Args) - if (Gbl.FileBrowser.FullTree) // if not full tree selected ==> do not put hidden parameter + if (FullTree) + if (*((bool *) FullTree)) // Put hidden parameter only if full tree selected Par_PutHiddenParamChar ("FullTree",'Y'); } @@ -12138,7 +12138,7 @@ static void Brw_PutLinkToAskRemOldFiles (void) extern const char *Txt_Remove_old_files; Lay_PutContextualLinkIconText (ActReqRemOldBrf,NULL, - Brw_PutHiddenParamFullTreeIfSelected,&Gbl, + Brw_PutHiddenParamFullTreeIfSelected,&Gbl.FileBrowser.FullTree, "trash.svg", Txt_Remove_old_files); } @@ -12161,7 +12161,7 @@ void Brw_AskRemoveOldFiles (void) /***** Begin form *****/ Frm_StartForm (ActRemOldBrf); - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Remove_old_files, diff --git a/swad_file_browser.h b/swad_file_browser.h index 03eb955f..43e77d21 100644 --- a/swad_file_browser.h +++ b/swad_file_browser.h @@ -195,7 +195,7 @@ void Brw_RemoveSomeInfoAboutCrsUsrFilesFromDB (long UsrCod,long CrsCod); void Brw_RemoveWrkFilesFromDB (long CrsCod,long UsrCod); void Brw_RemoveUsrFilesFromDB (long UsrCod); -void Brw_PutHiddenParamFullTreeIfSelected (void *Args); +void Brw_PutHiddenParamFullTreeIfSelected (void *FullTree); void Brw_CreateDirDownloadTmp (void); void Brw_AskEditWorksCrs (void *Args); diff --git a/swad_forum.c b/swad_forum.c index 0972618d..af27cb1a 100644 --- a/swad_forum.c +++ b/swad_forum.c @@ -344,7 +344,7 @@ static void For_PutHiddenParamThrCod (long ThrCod); static void For_PutHiddenParamPstCod (long PstCod); static void For_ShowForumList (struct For_Forums *Forums); -static void For_PutIconsForums (void *Args); +static void For_PutIconsForums (__attribute__((unused)) void *Args); static void For_PutFormWhichForums (const struct For_Forums *Forums); static void For_WriteLinksToGblForums (const struct For_Forums *Forums, @@ -1593,7 +1593,7 @@ static void For_ShowForumList (struct For_Forums *Forums) /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Forums, - For_PutIconsForums,&Gbl, + For_PutIconsForums,NULL, Hlp_MESSAGES_Forums,Box_NOT_CLOSABLE); /***** Put a form to select which forums *****/ @@ -1760,11 +1760,10 @@ static void For_ShowForumList (struct For_Forums *Forums) /********************** Put contextual icons in forums ***********************/ /*****************************************************************************/ -static void For_PutIconsForums (void *Args) +static void For_PutIconsForums (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_FORUMS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_FORUMS); } /*****************************************************************************/ diff --git a/swad_global.h b/swad_global.h index 92a70b4e..3ec690f9 100644 --- a/swad_global.h +++ b/swad_global.h @@ -634,10 +634,6 @@ struct Globals double MaxPercent; } DegPhotos; } Stat; - struct - { - char *Str; - } QR; /* Cache */ struct diff --git a/swad_icon.c b/swad_icon.c index 3a10053c..7441af90 100644 --- a/swad_icon.c +++ b/swad_icon.c @@ -66,7 +66,7 @@ const char *Ico_IconSetNames[Ico_NUM_ICON_SETS] = /***************************** Private prototypes ****************************/ /*****************************************************************************/ -static void Ico_PutIconsIconSet (void *Args); +static void Ico_PutIconsIconSet (__attribute__((unused)) void *Args); /*****************************************************************************/ /*********** Get icon with extension from icon without extension *************/ @@ -147,11 +147,10 @@ void Ico_PutIconsToSelectIconSet (void) /***************** Put contextual icons in icon-set setting *******************/ /*****************************************************************************/ -static void Ico_PutIconsIconSet (void *Args) +static void Ico_PutIconsIconSet (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_ICON_SETS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_ICON_SETS); } /*****************************************************************************/ diff --git a/swad_language.c b/swad_language.c index 06708247..9ef1d62b 100644 --- a/swad_language.c +++ b/swad_language.c @@ -65,7 +65,7 @@ const char *Lan_STR_LANG_ID[1 + Lan_NUM_LANGUAGES] = // ISO 639-1 language codes /****************************** Private prototypes ***************************/ /*****************************************************************************/ -static void Lan_PutIconsLanguage (void *Args); +static void Lan_PutIconsLanguage (__attribute__((unused)) void *Args); static void Lan_PutParamLanguage (void *Args); @@ -91,7 +91,7 @@ void Lan_PutBoxToSelectLanguage (void) extern const char *Txt_Language; Box_BoxBegin (NULL,Txt_Language, - Lan_PutIconsLanguage,&Gbl, + Lan_PutIconsLanguage,NULL, Hlp_PROFILE_Settings_language,Box_NOT_CLOSABLE); Lan_PutSelectorToSelectLanguage (); Box_BoxEnd (); @@ -101,11 +101,10 @@ void Lan_PutBoxToSelectLanguage (void) /**************** Put contextual icons in language setting *******************/ /*****************************************************************************/ -static void Lan_PutIconsLanguage (void *Args) +static void Lan_PutIconsLanguage (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_LANGUAGES); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_LANGUAGES); } /*****************************************************************************/ diff --git a/swad_menu.c b/swad_menu.c index a29053b1..c0a6cb43 100644 --- a/swad_menu.c +++ b/swad_menu.c @@ -176,7 +176,7 @@ static const Act_Action_t Mnu_MenuActions[Tab_NUM_TABS][Act_MAX_OPTIONS_IN_MENU_ /****************************** Private prototypes ***************************/ /*****************************************************************************/ -static void Mnu_PutIconsMenu (void *Args); +static void Mnu_PutIconsMenu (__attribute__((unused)) void *Args); /*****************************************************************************/ /******* When I change to another tab, go to the first option allowed ********/ @@ -276,7 +276,7 @@ void Mnu_PutIconsToSelectMenu (void) Mnu_Menu_t Menu; Box_BoxBegin (NULL,Txt_Menu, - Mnu_PutIconsMenu,&Gbl, + Mnu_PutIconsMenu,NULL, Hlp_PROFILE_Settings_menu,Box_NOT_CLOSABLE); Set_StartSettingsHead (); Set_StartOneSettingSelector (); @@ -301,11 +301,10 @@ void Mnu_PutIconsToSelectMenu (void) /******************* Put contextual icons in menu setting ********************/ /*****************************************************************************/ -static void Mnu_PutIconsMenu (void *Args) +static void Mnu_PutIconsMenu (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_MENUS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_MENUS); } /*****************************************************************************/ diff --git a/swad_network.c b/swad_network.c index c0d18188..fea5b39d 100644 --- a/swad_network.c +++ b/swad_network.c @@ -195,7 +195,7 @@ static const char *Net_WebsAndSocialNetworksTitle[Net_NUM_WEBS_AND_SOCIAL_NETWOR static void Net_ShowAWebOrSocialNet (const char *URL, const char *Icon,const char *Title); -static void Net_PutIconsWebsSocialNetworks (void *Args); +static void Net_PutIconsWebsSocialNetworks (__attribute__((unused)) void *Args); static void Net_GetMyWebsAndSocialNetsFromForm (void); @@ -287,7 +287,7 @@ void Net_ShowFormMyWebsAndSocialNets (void) "%upx", Rec_RECORD_WIDTH); Box_BoxBegin (StrRecordWidth,Txt_Webs_social_networks, - Net_PutIconsWebsSocialNetworks,&Gbl, + Net_PutIconsWebsSocialNetworks,NULL, Hlp_PROFILE_Webs,Box_NOT_CLOSABLE); /***** Begin table *****/ @@ -364,11 +364,10 @@ void Net_ShowFormMyWebsAndSocialNets (void) /************** Put contextual icons in my web / social networks *************/ /*****************************************************************************/ -static void Net_PutIconsWebsSocialNetworks (void *Args) +static void Net_PutIconsWebsSocialNetworks (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_SOCIAL_NETWORKS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_SOCIAL_NETWORKS); } /*****************************************************************************/ diff --git a/swad_notification.c b/swad_notification.c index 33a750a1..7dba1027 100644 --- a/swad_notification.c +++ b/swad_notification.c @@ -262,7 +262,7 @@ static const char *Ntf_Icons[Ntf_NUM_NOTIFY_EVENTS] = /***************************** Private prototypes ****************************/ /*****************************************************************************/ -static void Ntf_PutIconsNotif (void *Args); +static void Ntf_PutIconsNotif (__attribute__((unused)) void *Args); static void Ntf_WriteFormAllNotifications (bool AllNotifications); static bool Ntf_GetAllNotificationsFromForm (void); @@ -372,7 +372,7 @@ void Ntf_ShowMyNotifications (void) /***** Begin box *****/ Box_BoxBegin (NULL,Txt_Notifications, - Ntf_PutIconsNotif,&Gbl, + Ntf_PutIconsNotif,NULL, Hlp_START_Notifications,Box_NOT_CLOSABLE); /***** List my notifications *****/ @@ -619,11 +619,10 @@ void Ntf_ShowMyNotifications (void) /****************** Put contextual icons in notifications ********************/ /*****************************************************************************/ -static void Ntf_PutIconsNotif (void *Args) +static void Ntf_PutIconsNotif (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_NOTIFY_EVENTS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_NOTIFY_EVENTS); } /*****************************************************************************/ diff --git a/swad_privacy.c b/swad_privacy.c index 1ae0f16f..2af03ebd 100644 --- a/swad_privacy.c +++ b/swad_privacy.c @@ -66,7 +66,7 @@ const char *Pri_VisibilityDB[Pri_NUM_OPTIONS_PRIVACY] = /***************************** Private prototypes ****************************/ /*****************************************************************************/ -static void Pri_PutIconsPrivacy (void *Args); +static void Pri_PutIconsPrivacy (__attribute__((unused)) void *Args); static void Pri_PutFormVisibility (const char *TxtLabel, Act_Action_t Action,const char *ParamName, @@ -98,7 +98,7 @@ void Pri_EditMyPrivacy (void) /***** Begin box and table *****/ Box_BoxTableBegin (NULL,Txt_Privacy, - Pri_PutIconsPrivacy,&Gbl, + Pri_PutIconsPrivacy,NULL, Hlp_PROFILE_Settings_privacy,Box_NOT_CLOSABLE,2); /***** Edit photo visibility *****/ @@ -136,11 +136,10 @@ void Pri_EditMyPrivacy (void) /****************** Put contextual icons in privacy setting ******************/ /*****************************************************************************/ -static void Pri_PutIconsPrivacy (void *Args) +static void Pri_PutIconsPrivacy (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_PRIVACY); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_PRIVACY); } /*****************************************************************************/ diff --git a/swad_record.c b/swad_record.c index 6c933ef5..600b53f7 100644 --- a/swad_record.c +++ b/swad_record.c @@ -2643,7 +2643,7 @@ static void Rec_PutParamsWorks (void *Args) Rec_PutParamsStudent (&Gbl); Par_PutHiddenParamChar ("FullTree",'Y'); // By default, show all files Gbl.FileBrowser.FullTree = true; - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); } } diff --git a/swad_setting.c b/swad_setting.c index 8d368de7..31469518 100644 --- a/swad_setting.c +++ b/swad_setting.c @@ -61,7 +61,7 @@ extern struct Globals Gbl; /*****************************************************************************/ static void Set_PutIconsToSelectSideCols (void); -static void Set_PutIconsSideColumns (void *Args); +static void Set_PutIconsSideColumns (__attribute__((unused)) void *Args); static void Set_UpdateSideColsOnUsrDataTable (void); /*****************************************************************************/ @@ -249,7 +249,7 @@ static void Set_PutIconsToSelectSideCols (void) char Icon[32 + 1]; Box_BoxBegin (NULL,Txt_Columns, - Set_PutIconsSideColumns,&Gbl, + Set_PutIconsSideColumns,NULL, Hlp_PROFILE_Settings_columns,Box_NOT_CLOSABLE); Set_StartSettingsHead (); Set_StartOneSettingSelector (); @@ -277,11 +277,10 @@ static void Set_PutIconsToSelectSideCols (void) /************** Put contextual icons in side-columns setting *****************/ /*****************************************************************************/ -static void Set_PutIconsSideColumns (void *Args) +static void Set_PutIconsSideColumns (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_SIDE_COLUMNS); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_SIDE_COLUMNS); } /*****************************************************************************/ diff --git a/swad_theme.c b/swad_theme.c index d7c04fe8..e0b95685 100644 --- a/swad_theme.c +++ b/swad_theme.c @@ -304,7 +304,7 @@ const char *The_ClassFormOutBoxBold[The_NUM_THEMES] = /****************************** Private prototypes ***************************/ /*****************************************************************************/ -static void The_PutIconsTheme (void *Args); +static void The_PutIconsTheme (__attribute__((unused)) void *Args); /*****************************************************************************/ /************************ Put icons to select a theme ***********************/ @@ -318,7 +318,7 @@ void The_PutIconsToSelectTheme (void) char Icon[PATH_MAX + 1]; Box_BoxBegin (NULL,Txt_Theme_SKIN, - The_PutIconsTheme,&Gbl, + The_PutIconsTheme,NULL, Hlp_PROFILE_Settings_theme,Box_NOT_CLOSABLE); Set_StartSettingsHead (); Set_StartOneSettingSelector (); @@ -347,11 +347,10 @@ void The_PutIconsToSelectTheme (void) /****************** Put contextual icons in theme setting ********************/ /*****************************************************************************/ -static void The_PutIconsTheme (void *Args) +static void The_PutIconsTheme (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_THEMES); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_THEMES); } /*****************************************************************************/ diff --git a/swad_timeline.c b/swad_timeline.c index e7d933d0..5872651f 100644 --- a/swad_timeline.c +++ b/swad_timeline.c @@ -220,7 +220,7 @@ static void TL_DropTemporaryTablesUsedToQueryTimeline (void); static void TL_ShowTimeline (char *Query, const char *Title,long NotCodToHighlight); -static void TL_PutIconsTimeline (void *Args); +static void TL_PutIconsTimeline (__attribute__((unused)) void *Args); static void TL_FormStart (Act_Action_t ActionGbl,Act_Action_t ActionUsr); static void TL_FormFavSha (Act_Action_t ActionGbl,Act_Action_t ActionUsr, @@ -1088,7 +1088,7 @@ static void TL_ShowTimeline (char *Query, Query); /***** Begin box *****/ Box_BoxBegin (NULL,Title, - TL_PutIconsTimeline,&Gbl, + TL_PutIconsTimeline,NULL, Hlp_START_Timeline,Box_NOT_CLOSABLE); /***** Put form to select users whom public activity is displayed *****/ @@ -1161,11 +1161,10 @@ static void TL_ShowTimeline (char *Query, /********************* Put contextual icons in timeline **********************/ /*****************************************************************************/ -static void TL_PutIconsTimeline (void *Args) +static void TL_PutIconsTimeline (__attribute__((unused)) void *Args) { - if (Args) - /***** Put icon to show a figure *****/ - Fig_PutIconToShowFigure (Fig_TIMELINE); + /***** Put icon to show a figure *****/ + Fig_PutIconToShowFigure (Fig_TIMELINE); } /*****************************************************************************/ diff --git a/swad_user.c b/swad_user.c index d4bb9a03..3449fb74 100644 --- a/swad_user.c +++ b/swad_user.c @@ -6388,7 +6388,7 @@ void Usr_PutFormToSelectUsrsToGoToAct (struct SelectedUsrs *SelectedUsrs, if (NextAction == ActAdmAsgWrkCrs) { Gbl.FileBrowser.FullTree = true; // By default, show all files - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); } if (FuncParams) FuncParams (Args); diff --git a/swad_zip.c b/swad_zip.c index 6bf24e93..114be434 100644 --- a/swad_zip.c +++ b/swad_zip.c @@ -103,7 +103,7 @@ static void ZIP_PutLinkToCreateZIPAsgWrkParams (void *Args) if (Args) { Usr_PutHiddenParSelectedUsrsCods (&Gbl.Usrs.Selected); - Brw_PutHiddenParamFullTreeIfSelected (&Gbl); + Brw_PutHiddenParamFullTreeIfSelected (&Gbl.FileBrowser.FullTree); Par_PutHiddenParamChar ("CreateZIP",'Y'); } }