From 06483cca1db93a0e07350ce32bfc614fc4b86346 Mon Sep 17 00:00:00 2001 From: Alexander Cecile <35971201+AlexanderCecile@users.noreply.github.com> Date: Tue, 25 Aug 2020 20:48:35 -0400 Subject: [PATCH] Update error handling in get_file_by_url I don't believe the the .text could actually raise that exception. Oops. --- updateHostsFile.py | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/updateHostsFile.py b/updateHostsFile.py index 2a4bce297..60fd80d7a 100644 --- a/updateHostsFile.py +++ b/updateHostsFile.py @@ -1495,16 +1495,8 @@ def get_file_by_url(url, params=None, **kwargs): return None req.encoding = req.apparent_encoding - - try: - res_text = req.text - except UnicodeDecodeError: - print("Decoding error when retrieving data from {}".format(url)) - return None - - res = "\n".join([domain_to_idna(line) for line in res_text.split("\n")]) - - return res + res_text = "\n".join([domain_to_idna(line) for line in req.text.split("\n")]) + return res_text def write_data(f, data):