From 411c116debf97779ceb7b7c92a64a7cdb7fabb66 Mon Sep 17 00:00:00 2001 From: Kristian Date: Mon, 8 Jul 2019 15:20:56 +0200 Subject: [PATCH 1/3] Update qmltermwidget submodule --- qmltermwidget | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qmltermwidget b/qmltermwidget index 050193c..ae3bf9a 160000 --- a/qmltermwidget +++ b/qmltermwidget @@ -1 +1 @@ -Subproject commit 050193c128c0ae6367d5747cd4b9bb9aa73f3555 +Subproject commit ae3bf9aa34accbef83eb1eaa45d1373d1534e9ea From 9960b25dff271249fc774f222be799a2d87c36cb Mon Sep 17 00:00:00 2001 From: Kristian Date: Mon, 8 Jul 2019 15:21:17 +0200 Subject: [PATCH 2/3] Add support for blinking cursor --- app/qml/ApplicationSettings.qml | 7 ++++++- app/qml/PreprocessedTerminal.qml | 1 + app/qml/SettingsTerminalTab.qml | 18 ++++++++++++++++++ 3 files changed, 25 insertions(+), 1 deletion(-) diff --git a/app/qml/ApplicationSettings.qml b/app/qml/ApplicationSettings.qml index 11d4330..412af96 100644 --- a/app/qml/ApplicationSettings.qml +++ b/app/qml/ApplicationSettings.qml @@ -59,6 +59,8 @@ QtObject{ property real burnInQuality: 0.5 property bool useFastBurnIn: Qt.platform.os === "osx" ? false : true + property bool blinkingCursor: true + onWindowScalingChanged: handleFontChanged(); // PROFILE SETTINGS /////////////////////////////////////////////////////// @@ -208,7 +210,8 @@ QtObject{ burnInQuality: burnInQuality, useCustomCommand: useCustomCommand, customCommand: customCommand, - useFastBurnIn: useFastBurnIn + useFastBurnIn: useFastBurnIn, + blinkingCursor: blinkingCursor } return stringify(settings); } @@ -296,6 +299,8 @@ QtObject{ customCommand = settings.customCommand !== undefined ? settings.customCommand : customCommand useFastBurnIn = settings.useFastBurnIn !== undefined ? settings.useFastBurnIn : useFastBurnIn; + + blinkingCursor = settings.blinkingCursor !== undefined ? settings.blinkingCursor : blinkingCursor } function loadProfileString(profileString){ diff --git a/app/qml/PreprocessedTerminal.qml b/app/qml/PreprocessedTerminal.qml index d0d9cee..cb8698c 100644 --- a/app/qml/PreprocessedTerminal.qml +++ b/app/qml/PreprocessedTerminal.qml @@ -94,6 +94,7 @@ Item{ smooth: !appSettings.lowResolutionFont enableBold: false fullCursorHeight: true + blinkingCursor: appSettings.blinkingCursor session: QMLTermSession { id: ksession diff --git a/app/qml/SettingsTerminalTab.qml b/app/qml/SettingsTerminalTab.qml index 8cefdb8..914a90c 100644 --- a/app/qml/SettingsTerminalTab.qml +++ b/app/qml/SettingsTerminalTab.qml @@ -114,6 +114,24 @@ Tab{ } } } + GroupBox{ + title: qsTr("Cursor") + Layout.fillWidth: true + ColumnLayout { + anchors.fill: parent + CheckBox{ + id: blinkingCursor + text: qsTr("Blinking Cursor") + checked: appSettings.blinkingCursor + onCheckedChanged: appSettings.blinkingCursor = checked + } + Binding{ + target: blinkingCursor + property: "checked" + value: appSettings.blinkingCursor + } + } + } GroupBox{ title: qsTr("Colors") Layout.fillWidth: true From 8d7565ffc49eb97447d93820ea9dee5210171330 Mon Sep 17 00:00:00 2001 From: Kristian Date: Sat, 20 Jul 2019 16:51:10 +0200 Subject: [PATCH 3/3] Disable blinking cursor by default --- app/qml/ApplicationSettings.qml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/app/qml/ApplicationSettings.qml b/app/qml/ApplicationSettings.qml index 412af96..d7a3866 100644 --- a/app/qml/ApplicationSettings.qml +++ b/app/qml/ApplicationSettings.qml @@ -59,7 +59,7 @@ QtObject{ property real burnInQuality: 0.5 property bool useFastBurnIn: Qt.platform.os === "osx" ? false : true - property bool blinkingCursor: true + property bool blinkingCursor: false onWindowScalingChanged: handleFontChanged();