From b6633e7e0d3a676534c5b334e9165e558b6c0cc3 Mon Sep 17 00:00:00 2001
From: Alejandro Alcalde <algui91@gmail.com>
Date: Sun, 10 Aug 2014 21:58:37 +0200
Subject: [PATCH] Fix Calling getter method * on self is slower than field
 access *

---
 SWADroid/lint.xml                             | 211 ++----------------
 .../com/android/dataframework/core/Field.java |   4 +-
 .../src/es/ugr/swad/swadroid/model/Group.java |   2 +-
 .../downloads/FileDownloaderAsyncTask.java    |   2 +-
 4 files changed, 18 insertions(+), 201 deletions(-)

diff --git a/SWADroid/lint.xml b/SWADroid/lint.xml
index b8810ab9..ff169500 100644
--- a/SWADroid/lint.xml
+++ b/SWADroid/lint.xml
@@ -1,200 +1,17 @@
 <?xml version="1.0" encoding="UTF-8"?>
 <lint>
-    <issue id="AaptCrash" severity="ignore" />
-    <issue id="AccidentalOctal" severity="ignore" />
-    <issue id="AdapterViewChildren" severity="ignore" />
-    <issue id="AddJavascriptInterface" severity="ignore" />
-    <issue id="AllowBackup" severity="ignore" />
-    <issue id="AlwaysShowAction" severity="ignore" />
-    <issue id="AndroidGradlePluginVersion" severity="ignore" />
-    <issue id="AppCompatMethod" severity="ignore" />
-    <issue id="AppCompatResource" severity="ignore" />
-    <issue id="Assert" severity="ignore" />
-    <issue id="BackButton" severity="ignore" />
-    <issue id="ButtonCase" severity="ignore" />
-    <issue id="ButtonOrder" severity="ignore" />
-    <issue id="ButtonStyle" severity="ignore" />
-    <issue id="ByteOrderMark" severity="ignore" />
-    <issue id="ClickableViewAccessibility" severity="ignore" />
-    <issue id="CommitPrefEdits" severity="ignore" />
-    <issue id="CommitTransaction" severity="ignore" />
-    <issue id="ContentDescription" severity="ignore" />
-    <issue id="CutPasteId" severity="ignore" />
-    <issue id="DalvikOverride" severity="ignore" />
-    <issue id="DefaultLocale" severity="ignore" />
-    <issue id="Deprecated" severity="ignore" />
-    <issue id="DeviceAdmin" severity="ignore" />
-    <issue id="DisableBaselineAlignment" severity="ignore" />
-    <issue id="DrawAllocation" severity="ignore" />
-    <issue id="DuplicateActivity" severity="ignore" />
-    <issue id="DuplicateDefinition" severity="ignore" />
-    <issue id="DuplicateIds" severity="ignore" />
-    <issue id="DuplicateIncludedIds" severity="ignore" />
-    <issue id="DuplicateUsesFeature" severity="ignore" />
-    <issue id="EasterEgg" severity="ignore" />
-    <issue id="EnforceUTF8" severity="ignore" />
-    <issue id="ExportedContentProvider" severity="ignore" />
-    <issue id="ExportedPreferenceActivity" severity="ignore" />
-    <issue id="ExportedReceiver" severity="ignore" />
-    <issue id="ExportedService" severity="ignore" />
-    <issue id="ExtraText" severity="ignore" />
-    <issue id="ExtraTranslation" severity="ignore" />
-    <issue id="FieldGetter" severity="ignore" />
-    <issue id="FloatMath" severity="ignore" />
-    <issue id="GetInstance" severity="ignore" />
-    <issue id="GifUsage" severity="ignore" />
-    <issue id="GradleCompatible" severity="ignore" />
-    <issue id="GradleDependency" severity="ignore" />
-    <issue id="GradleDeprecated" severity="ignore" />
-    <issue id="GradleDynamicVersion" severity="ignore" />
-    <issue id="GradleGetter" severity="ignore" />
-    <issue id="GradleIdeError" severity="ignore" />
-    <issue id="GradleOverrides" severity="ignore" />
-    <issue id="GradlePath" severity="ignore" />
-    <issue id="GrantAllUris" severity="ignore" />
-    <issue id="GridLayout" severity="ignore" />
-    <issue id="HandlerLeak" severity="ignore" />
-    <issue id="HardcodedDebugMode" severity="ignore" />
-    <issue id="HardcodedText" severity="ignore" />
-    <issue id="IconColors" severity="ignore" />
-    <issue id="IconDensities" severity="ignore" />
-    <issue id="IconDipSize" severity="ignore" />
-    <issue id="IconDuplicates" severity="ignore" />
-    <issue id="IconDuplicatesConfig" severity="ignore" />
-    <issue id="IconExpectedSize" severity="ignore" />
-    <issue id="IconExtension" severity="ignore" />
-    <issue id="IconLauncherShape" severity="ignore" />
-    <issue id="IconLocation" severity="ignore" />
-    <issue id="IconMissingDensityFolder" severity="ignore" />
-    <issue id="IconMixedNinePatch" severity="ignore" />
-    <issue id="IconNoDpi" severity="ignore" />
-    <issue id="IconXmlAndPng" severity="ignore" />
-    <issue id="IllegalResourceRef" severity="ignore" />
-    <issue id="ImpliedQuantity" severity="ignore" />
-    <issue id="ImproperProjectLevelStatement" severity="ignore" />
-    <issue id="InOrMmUsage" severity="ignore" />
-    <issue id="IncludeLayoutParam" severity="ignore" />
-    <issue id="InconsistentArrays" severity="ignore" />
-    <issue id="InconsistentLayout" severity="ignore" />
-    <issue id="InefficientWeight" severity="ignore" />
-    <issue id="InflateParams" severity="ignore" />
-    <issue id="InlinedApi" severity="ignore" />
-    <issue id="InnerclassSeparator" severity="ignore" />
-    <issue id="Instantiatable" severity="ignore" />
-    <issue id="InvalidId" severity="ignore" />
-    <issue id="InvalidPackage" severity="ignore" />
-    <issue id="JavascriptInterface" severity="ignore" />
-    <issue id="LabelFor" severity="ignore" />
-    <issue id="LibraryCustomView" severity="ignore" />
-    <issue id="LocalSuppress" severity="ignore" />
-    <issue id="LocaleFolder" severity="ignore" />
-    <issue id="MangledCRLF" severity="ignore" />
-    <issue id="ManifestOrder" severity="ignore" />
-    <issue id="ManifestTypo" severity="ignore" />
-    <issue id="MenuTitle" severity="ignore" />
-    <issue id="MergeRootFrame" severity="ignore" />
-    <issue id="MisplacedStatement" severity="ignore" />
-    <issue id="MissingApplicationIcon" severity="ignore" />
-    <issue id="MissingId" severity="ignore" />
-    <issue id="MissingPrefix" severity="ignore" />
-    <issue id="MissingQuantity" severity="ignore" />
-    <issue id="MissingRegistered" severity="ignore" />
-    <issue id="MissingSuperCall" severity="ignore" />
-    <issue id="MissingTranslation" severity="ignore" />
-    <issue id="MissingVersion" severity="ignore" />
-    <issue id="MockLocation" severity="ignore" />
-    <issue id="MultipleUsesSdk" severity="ignore" />
-    <issue id="NamespaceTypo" severity="ignore" />
-    <issue id="NestedScrolling" severity="ignore" />
-    <issue id="NestedWeights" severity="ignore" />
-    <issue id="NewApi" severity="ignore" />
-    <issue id="NewerVersionAvailable" severity="ignore" />
-    <issue id="NfcTechWhitespace" severity="ignore" />
-    <issue id="NotSibling" severity="ignore" />
-    <issue id="ObsoleteLayoutParam" severity="ignore" />
-    <issue id="OldTargetApi" severity="ignore" />
-    <issue id="OnClick" severity="ignore" />
-    <issue id="Orientation" severity="ignore" />
-    <issue id="Overdraw" severity="ignore" />
-    <issue id="Override" severity="ignore" />
-    <issue id="PackagedPrivateKey" severity="ignore" />
-    <issue id="ParcelCreator" severity="ignore" />
-    <issue id="PrivateResource" severity="ignore" />
-    <issue id="Proguard" severity="ignore" />
-    <issue id="ProguardSplit" severity="ignore" />
-    <issue id="PropertyEscape" severity="ignore" />
-    <issue id="ProtectedPermissions" severity="ignore" />
-    <issue id="PxUsage" severity="ignore" />
-    <issue id="Recycle" severity="ignore" />
-    <issue id="ReferenceType" severity="ignore" />
-    <issue id="Registered" severity="ignore" />
-    <issue id="RequiredSize" severity="ignore" />
-    <issue id="ResAuto" severity="ignore" />
-    <issue id="ResourceAsColor" severity="ignore" />
-    <issue id="ResourceCycle" severity="ignore" />
-    <issue id="ResourceName" severity="ignore" />
-    <issue id="RtlCompat" severity="ignore" />
-    <issue id="RtlEnabled" severity="ignore" />
-    <issue id="RtlHardcoded" severity="ignore" />
-    <issue id="RtlSymmetry" severity="ignore" />
-    <issue id="ScrollViewCount" severity="ignore" />
-    <issue id="ScrollViewSize" severity="ignore" />
-    <issue id="SdCardPath" severity="ignore" />
-    <issue id="SecureRandom" severity="ignore" />
-    <issue id="SelectableText" severity="ignore" />
-    <issue id="ServiceCast" severity="ignore" />
-    <issue id="SetJavaScriptEnabled" severity="ignore" />
-    <issue id="ShowToast" severity="ignore" />
-    <issue id="SignatureOrSystemPermissions" severity="ignore" />
-    <issue id="SimpleDateFormat" severity="ignore" />
-    <issue id="SmallSp" severity="ignore" />
-    <issue id="SpUsage" severity="ignore" />
-    <issue id="StateListReachable" severity="ignore" />
-    <issue id="StopShip" severity="ignore" />
-    <issue id="StringFormatCount" severity="ignore" />
-    <issue id="StringFormatInvalid" severity="ignore" />
-    <issue id="StringFormatMatches" severity="ignore" />
-    <issue id="StringShouldBeInt" severity="ignore" />
-    <issue id="Suspicious0dp" severity="ignore" />
-    <issue id="SuspiciousImport" severity="ignore" />
-    <issue id="TextFields" severity="ignore" />
-    <issue id="TextViewEdits" severity="ignore" />
-    <issue id="TooDeepLayout" severity="ignore" />
-    <issue id="TooManyViews" severity="ignore" />
-    <issue id="TrulyRandom" severity="ignore" />
-    <issue id="TypographyDashes" severity="ignore" />
-    <issue id="TypographyEllipsis" severity="ignore" />
-    <issue id="TypographyFractions" severity="ignore" />
-    <issue id="TypographyOther" severity="ignore" />
-    <issue id="TypographyQuotes" severity="ignore" />
-    <issue id="Typos" severity="ignore" />
-    <issue id="UniquePermission" severity="ignore" />
-    <issue id="UnknownId" severity="ignore" />
-    <issue id="UnknownIdInLayout" severity="ignore" />
-    <issue id="UnlocalizedSms" severity="ignore" />
-    <issue id="UnusedAttribute" severity="ignore" />
-    <issue id="UnusedIds" severity="ignore" />
-    <issue id="UnusedNamespace" severity="ignore" />
-    <issue id="UnusedQuantity" severity="ignore" />
-    <issue id="UnusedResources" severity="ignore" />
-    <issue id="UseCheckPermission" severity="ignore" />
-    <issue id="UseCompoundDrawables" severity="ignore" />
-    <issue id="UseSparseArrays" severity="ignore" />
-    <issue id="UseValueOf" severity="ignore" />
-    <issue id="UselessLeaf" severity="ignore" />
-    <issue id="UselessParent" severity="ignore" />
-    <issue id="UsesMinSdkAttributes" severity="ignore" />
-    <issue id="ValidFragment" severity="ignore" />
-    <issue id="ViewConstructor" severity="ignore" />
-    <issue id="ViewHolder" severity="ignore" />
-    <issue id="ViewTag" severity="ignore" />
-    <issue id="Wakelock" severity="ignore" />
-    <issue id="WebViewLayout" severity="ignore" />
-    <issue id="WorldReadableFiles" severity="ignore" />
-    <issue id="WorldWriteableFiles" severity="ignore" />
-    <issue id="WrongCall" severity="ignore" />
-    <issue id="WrongCase" severity="ignore" />
-    <issue id="WrongFolder" severity="ignore" />
-    <issue id="WrongManifestParent" severity="ignore" />
-    <issue id="WrongViewCast" severity="ignore" />
+    <issue id="BackButton" severity="warning" />
+    <issue id="EasterEgg" severity="warning" />
+    <issue id="FieldGetter" severity="warning" />
+    <issue id="GradleDynamicVersion" severity="warning" />
+    <issue id="IconExpectedSize" severity="warning" />
+    <issue id="NewerVersionAvailable" severity="warning" />
+    <issue id="RtlCompat" severity="error" />
+    <issue id="RtlEnabled" severity="warning" />
+    <issue id="RtlHardcoded" severity="warning" />
+    <issue id="RtlSymmetry" severity="error" />
+    <issue id="SelectableText" severity="warning" />
+    <issue id="StopShip" severity="warning" />
+    <issue id="TypographyQuotes" severity="warning" />
+    <issue id="UnusedIds" severity="warning" />
 </lint>
\ No newline at end of file
diff --git a/SWADroid/src/com/android/dataframework/core/Field.java b/SWADroid/src/com/android/dataframework/core/Field.java
index 8ee3ba9e..9ce23225 100644
--- a/SWADroid/src/com/android/dataframework/core/Field.java
+++ b/SWADroid/src/com/android/dataframework/core/Field.java
@@ -90,8 +90,8 @@ public class Field {
 		sql += " " + getSQLType();
 		if (mObligatory)
 			sql += " not null";
-		if (getTextDefault()!=null) {
-			sql += " DEFAULT '" + getTextDefault() + "'";
+		if (mTextDefault!=null) {
+			sql += " DEFAULT '" + mTextDefault + "'";
 		}
 
 		return sql;
diff --git a/SWADroid/src/es/ugr/swad/swadroid/model/Group.java b/SWADroid/src/es/ugr/swad/swadroid/model/Group.java
index 7c718b36..ae1b785e 100644
--- a/SWADroid/src/es/ugr/swad/swadroid/model/Group.java
+++ b/SWADroid/src/es/ugr/swad/swadroid/model/Group.java
@@ -193,7 +193,7 @@ public class Group extends Model {
     @Override
     public String toString() {
         return "Group [name=" + groupName + ", getId()=" + getId() + ", getGroupTypeCode()=" + groupTypeCode + ", getMaxStudents()=" + maxStudents + ", getCurrentStudents()="
-                + getCurrentStudents() + ", getOpen()=" + getOpen() + ", getDocumentsArea()=" + getDocumentsArea() + ", getMember()= " + getMember();
+                + students + ", getOpen()=" + open + ", getDocumentsArea()=" + fileZones + ", getMember()= " + member;
     }
 
     /**
diff --git a/SWADroid/src/es/ugr/swad/swadroid/modules/downloads/FileDownloaderAsyncTask.java b/SWADroid/src/es/ugr/swad/swadroid/modules/downloads/FileDownloaderAsyncTask.java
index fe55a788..8988d084 100644
--- a/SWADroid/src/es/ugr/swad/swadroid/modules/downloads/FileDownloaderAsyncTask.java
+++ b/SWADroid/src/es/ugr/swad/swadroid/modules/downloads/FileDownloaderAsyncTask.java
@@ -136,7 +136,7 @@ public class FileDownloaderAsyncTask extends AsyncTask<String, Integer, Boolean>
         //			basename = "tmp";
 
         try {
-            File output = new File(this.getDownloadDir(), this.fileName);
+            File output = new File(download_dir, this.fileName);
             if (output.exists()) {
                 int i = 1;
                 do {